qrep pgvalue #1733
Merged
qrep pgvalue #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
pgvalue-qrep
branch
2 times, most recently
from
66fc5a7 to
e9dfc7d
Compare
|
|
|
postgis is failing in decode/encode mix up, jackc/pgx#867 outlines using lower level pgconn api to pipe |
serprex
force-pushed
the
pgvalue-qrep
branch
2 times, most recently
from
b956381 to
6abba93
Compare
kinda silly decoding values only to reencode, but getting around would mean lifting pgx code to send copy ourselves
…gx.Tx, as is query sanitization
iskakaushik
reviewed
May 28, 2024
iskakaushik
reviewed
May 28, 2024
iskakaushik
approved these changes
May 28, 2024
iskakaushik
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ends up being pretty different from cdc pgvalue, but makes sense since pgvalue isn't a type so a much as an idea that intermediate formats should be discarded
Instead of using channels & cursors, qrep pgvalue pipes COPY TO STDOUT from source into COPY FROM STDIN on destination
Values transmit as text protocol for maximum compatibility for now. Future PRs may add options, current PR is large enough already